search

bitsadmin / wesng

Windows Exploit Suggester - Next Generation
BSD 3-Clause "New" or "Revised" License
4.21k stars 568 forks source link

Potential Code Re-Factor and Bug Fixes #51

Closed HarshCasper closed 3 years ago

HarshCasper commented 3 years ago

Summary

This pull request removes the unnecessary use of Comprehension and changes methods not using its bound instance to staticmethods.

Importance

I ran a DeepSource Analysis on my fork of this repository. You can see all the issues raised by DeepSource here.

There are plenty of other issues in relation to Bug Discovery and Anti-Patterns which you would be interested to take a look at.

If you do not want to use DeepSource to continuously analyze this repo, I'll remove the .deepsource.toml from this PR and you can merge the rest of the fixes. If you want to setup DeepSource for Continuous Analysis, I can help you set that up.

HarshCasper commented 3 years ago

Hi @bitsadmin

Can you kindly have a look at this PR? Thanks a lot!