Open tcdent opened 3 months ago
Hey @tcdent, really cool, looks nice! Happy to see that you're taking the initiative 🤗
However, any specific reason why you merged main
? We're keeping things separate for the time being, so this messes up the diff and we also don't want everything from main
in multi-backend-refactor
; especially not mixed in with a PR, makes it hard to review.
Happy to give this a look soon. Better to revert the merge from main though, if you can.
Sorry, sloppy on my part. This work is a tangent of some tests I was trying to do, which needed both branches to be up-to-date.
Is a revert OK? I can also re-open a fresh PR.
@tcdent Could you please update us on the status of this PR. Is this work still foreseen, are the benefits of what's there already self-contained and ready to be merged?
Sorry for these questions, we have a huge task load right now, in need for triage, and I would like to get your opinion on this before looking deeper into the matter.
Thanks so much for your initiative on this PR in the first place!
Got Metal -> pyobjc++ -> Python loading.
quantize_mps
doesn't segfault. Start ofquantize_nf4
in the public API.Builds with:
$ cmake -DCOMPUTE_BACKEND=mps -S . && make
tensor([ 51, 51, 255, 255, 51, 51, 51, 51, 51, 51], dtype=torch.uint8)