bitsandbytes-foundation / bitsandbytes

Accessible large language models via k-bit quantization for PyTorch.
https://huggingface.co/docs/bitsandbytes/main/en/index
MIT License
6.14k stars 616 forks source link

Triton now replaces `triton.language.libdevice` with `triton.language.mathlib` #909

Open LemurPwned opened 10 months ago

LemurPwned commented 10 months ago

It seems that triton has recently switched to mathlib in lieu of libdevice which causes following errors in nn.triton_based_modules:

AttributeError: module 'triton.language' has no attribute 'libdevice'

Ref PRs from triton:

For example, triton.language.libdevice.llrint used here is now triton.language.math.llrint: https://github.com/openai/triton/blob/720d12c1433e5b13eb3a18d1e065c1d3d25a32f1/python/triton/language/math.py#L1096

Is this a simple update or bumping triton might break more stuff?

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Titus-von-Koeller commented 7 months ago

Thanks @LemurPwned for raising this! I would have to take a deeper look. I put it on my maintenance backlog. It might take a while until I get around to it, because there's so much going on / to catch up with.

In case you would willing to submit a PR and test it, that would really help a lot.

LemurPwned commented 7 months ago

Thanks @Titus-von-Koeller -- I'll try to make time to do a PR, but I'm not sure I'll be able to test a lot of corner cases.

Titus-von-Koeller commented 7 months ago

We can do that together :)