search

bitsbeats / drone-tree-config

Drone helper for mono repositories.
Apache License 2.0
103 stars 24 forks source link

Add gitlab API #19

Closed jezhodges closed 4 years ago

jezhodges commented 4 years ago

Adds support for Gitlab repositories

jezhodges commented 4 years ago

Cc'ing @foosinn

foosinn commented 4 years ago

Nice work @jezhodges!

I'll update our test environment during the week and merge afterwards. Thanks!

foosinn commented 4 years ago

Hey, any reason why you went with after~1 instead of master? May the default branch is the right thing to use here?

jezhodges commented 4 years ago

@foosinn if you are updating master directly, you cannot compare a SHA ref and master as master will be the latest.

So sha ref -> merge to master -> master so you can't compare, certainly in the Gitlab API. Interestingly the Gitlab API provides the Before SHA and After SHA but Drone doesn't pass it through so I might investigate if that's a bug in Drone.

foosinn commented 4 years ago

Good catch!