search

bitsbeats / drone-tree-config

Drone helper for mono repositories.
Apache License 2.0
103 stars 24 forks source link

Add consider repo config fallback option #47

Open PierreJeanjacquot opened 8 months ago

PierreJeanjacquot commented 8 months ago

Repo config fallback option when consider file is not found

The consider file feature is great, but you must set a configure file in all your repositories, whether it's a mono-repo or not. With many repositories (mono-repo and standard repo), this can be tedious. We went into this issue while refactoring our codebase into mono-repos.

This PR adds the option PLUGIN_CONSIDER_REPO_CONFIG to allow falling back to the drone configuration of the repository when the server defines a PLUGIN_CONSIDER_FILE but the repository does not have one.

mach6 commented 8 months ago

you must set a configure file in all your repositories, whether it's a mono-repo or not.

Have you looked at the config option PLUGIN_ALLOW_LIST_FILE? This is how you control this behavior.

PierreJeanjacquot commented 8 months ago

Yes, that's a good point, thank you @mach6! Unfortunately, the development team has no access to configure the drone server deployment in our organization, which adds some friction in the process of keeping the drone configuration up to date... I'll check what suits the best for us :+1:

PierreJeanjacquot commented 7 months ago

Update, I finally got access to drone deployment to update the allow list and I didn't need the fallback anymore :smiley: I leave the PR open but feel free to close it if you think this feature isn't needed :+1: