search

bitsed / qosmic

A flam3 fractal image editor
GNU General Public License v3.0
64 stars 13 forks source link

Unreadable text on the "Variations" panel #45

Closed denilsonsa closed 8 months ago

denilsonsa commented 8 months ago

When running Qosmic while having a dark desktop theme, the "Variations" panel will have white text on top of white background:

Qosmic screenshot

The "Chaos" panel seems to use a similar widget, and it is perfectly readable:

Qosmic screenshot - Chaos panel

System information

denilsonsa commented 8 months ago

I've prepared a quick patch that solves the issue:

Screenshot of the Variations panel following the user's theme

I'm sending a pull request.

bitsed commented 8 months ago

Hi. Thank you for the bug report and the patch in #46. It's been merged with the master branch.

I've created an alternative patch that may solve your problem and keep the highlighted text behavior. It can be found at the head of the issues-46 branch. https://github.com/bitsed/qosmic/compare/issues-46

I'm not easily able to test it right now. I don't have KDE/Plasma or dark themes installed. I'd appreciate your help if you're able to build and test issues-46. Thanks!

denilsonsa commented 8 months ago

Seems to be working fine:

image

I could complain that it is now hard to see which item currently has focus, because the focus color is the same as the background color of modified items. Maybe just setting them as bold would be good enough?

Also, maybe slightly increasing the column width as well.

Beyond this quick feedback, your patch seems to work well enough, thank you!