bitshares / beet-js

BeetJS is the client library for interaction with Beet
MIT License
8 stars 14 forks source link

Relink not working as intended #49

Open sschiessl-bcp opened 2 years ago

sschiessl-bcp commented 2 years ago

When executing the same example twice, it asks me also in the second run to decide which account. This UX needs to be re-evaluated as I think it should not ask for account again

https://github.com/bitshares/beet-js/blob/develop/examples/bitshares/signedMessage.js

grctest commented 2 years ago

Started work on improving this relink UX https://github.com/BTS-CM/beet-esm/commit/0ee2b5895fea54c5cfc0561a0cd64204f415ad19

grctest commented 2 years ago

I've created the following pull request to address this concern: https://github.com/bitshares/beet-js/pull/50

I'll update the readme to reference the need to store identity for relink purposes soon.

I've also introduced changes to the beet client, however I ran into some issues creating the pull request: https://github.com/bitshares/beet/issues/185

grctest commented 2 years ago

I've submitted a BEET wallet pull request https://github.com/bitshares/beet/pull/186

I'm now confident that these two pull requests fix the issue you've reported.

grctest commented 1 year ago

Fixed now, right?