search

bitshares / beet-js

BeetJS is the client library for interaction with Beet
MIT License
8 stars 14 forks source link

Extra examples #54

Closed grctest closed 1 year ago

grctest commented 2 years ago

Work in progress

Related to: https://github.com/bitshares/beet/pull/207

grctest commented 2 years ago

Operations 32, 34, 36, 69 and 71 need a peer review, I wasn't sure what the input format was supposed to be like where marked // TODO: DEBUG

Also, should blank future extensions be included as extensions: [] or extensions: null?

abitmore commented 2 years ago

Also, should blank future extensions be included as extensions: [] or extensions: null?

IIRC API nodes always accept extensions: [], and for some operations extensions: {}, but not always accept extensions: null.

sschiessl-bcp commented 1 year ago

With the current beet rc I get stuck doing this

>> node ./bitshares/injections/001_limit_order_create.js 
received connected socket response
socket: authenticated
Connected to Beet
sending link request
sending linkRequest request
sending api request

No popup visible. Which Beet version / commit hash are you using?

grctest commented 1 year ago

@sschiessl-bcp Please use the following Beet PR: https://github.com/bitshares/beet/pull/222

I've introduced several fixes to address the issue you ran into, including:

I too wasn't getting the prompt, now I do get it in both production and testnet. If the prompt still doesn't show, try different asset ids etc?

sschiessl-bcp commented 1 year ago

see https://github.com/bitshares/beet/pull/222