search

bitshares / beet

Beet is a stand-alone key/identity-manager and signing app for BitShares, heavily influenced by Scatter.
MIT License
27 stars 32 forks source link

New upload json feature, fixes & optimizations #247

Closed grctest closed 1 year ago

grctest commented 1 year ago

Implement new upload JSON feature to address https://github.com/bitshares/beet/issues/246

Introduced a fix for TUSC: https://github.com/bitshares/beet/issues/248

Introduces optimized account/asset lookup for all BTS operations: https://github.com/bitshares/beet/issues/249

Fix balances rendering properly: https://github.com/bitshares/beet/issues/255

Localizes the contents of BTS blockchain based injected operation prompts: #252

Resolves #256

grctest commented 1 year ago

Localization needs further work, it seems the machine translations translated the variables, resulting in missing fields when switching between languages.

Edit: Resolved!

sschiessl-bcp commented 1 year ago

this has conflicts?

grctest commented 1 year ago

this has conflicts?

It seems to only be the package lock file which is conflicting?

The package file was updated, I tried deleting the lock file but appveyor hasn't resolved the conflict despite the file no longer existing.

The package json file has been updated to use the new QR code package

grctest commented 1 year ago

What do you think of the new operation viewer & paginator component?

My only reservation with it is that in its current format that a 3rd party app could sneak in an operation and the user doesn't check it, if there's several thousand operations in the prompt.

What do you think about separate paginating operation components for different operation types? That way all the transfers would be grouped together, and any non-transfers would be visible below the transfers for example? It might be a bit of a cluttered edge case to resolve

sschiessl-bcp commented 1 year ago

What do you think of the new operation viewer & paginator component?

My only reservation with it is that in its current format that a 3rd party app could sneak in an operation and the user doesn't check it, if there's several thousand operations in the prompt.

What do you think about separate paginating operation components for different operation types? That way all the transfers would be grouped together, and any non-transfers would be visible below the transfers for example? It might be a bit of a cluttered edge case to resolve

Any user that executes thousands operations is probably a power user, and will not need special considerations and protection

grctest commented 1 year ago

Cool, in that case I feel that both #247 and #257 are ready for merge :)

Any other change requests?