bitshares / beet

Beet is a stand-alone key/identity-manager and signing app for BitShares, heavily influenced by Scatter.
MIT License
27 stars 32 forks source link

Prompt window remains open despite wallet timeout lockout triggering #250

Open grctest opened 1 year ago

grctest commented 1 year ago

Describe the bug

If my wallet locks due to timing out from inactivity, any prompts which were active at the time will remain open despite the underlying wallet having locked.

To Reproduce

Unlock your Beet wallet, create a prompt, go inactive for several minutes in order for the wallet timeout lock to trigger, navigate to still open prompt with a locked wallet.

Expected behavior

If a wallet is locked, the prompt window closes.

Additional context

Note: Attempts to approve prompts will fail whilst the wallet is locked, and new prompts will not trigger whilst locked.

Alternatively, since broadcasting whilst locked is impossible then it's not a security concern, we could allow the user to build up dozens of 15k op TRX over several hours & multiple wallet timeouts, then when prepared properly they can approve multiple in short succession..