search

bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 647 forks source link

Get around CURLOPT_POSTFIELDS bug, fix node crash #2491

Closed abitmore closed 3 years ago

abitmore commented 3 years ago

Fixes #2490.

Without the https://github.com/curl/curl/pull/3549 patch, there will be a strlen call on the uninitialized CURLOPT_POSTFIELDS field which causes crash.

With this pull request, CURLOPT_POSTFIELDS is always initialized.

Update: this patch is not ideal. See the updated issue description for more info.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

abitmore commented 3 years ago

The issue is random, the fix is incorrect.