Performance issue in 6.0

[abitmore]

Description

It's reported that the 6.0 version replays much slower than earlier versions.

I guess it's a side-effect of https://github.com/bitshares/bitshares-core/pull/2528 . Need profiling to know more.

Impacts Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

• [ ] API (the application programming interface)
• [ ] Build (the build process or something prior to compiled code)
• [ ] CLI (the command line wallet)
• [ ] Deployment (the deployment process after building such as Docker, Travis, etc.)
• [ ] DEX (the Decentralized EXchange, market engine, etc.)
• [ ] P2P (the peer-to-peer network for transaction/block propagation)
• [x] Performance (system or user efficiency, etc.)
• [ ] Protocol (the blockchain logic, consensus, validation, etc.)
• [ ] Security (the security of system or user data, etc.)
• [ ] UX (the User Experience)
• [ ] Other (please add below)

CORE TEAM TASK LIST

• [ ] Evaluate / Prioritize Bug Report
• [ ] Refine User Stories / Requirements
• [ ] Define Test Cases
• [ ] Design / Develop Solution
• [ ] Perform QA/Testing
• [ ] Update Documentation

[abitmore]

Data from one of my API nodes (max-ops=1200, RAM used 28G/30G, SWAP used 0G), replay times when released:

• an earlier version 23495 seconds
• 5.1.0 25218 seconds
• 5.2.1 25251 seconds
• 6.0.0 26881 seconds

Looks like there is no big difference. Note: 6.0.0 spent 20+ more minutes and process 6 more months of data.

[abitmore]

Another node with similar hardware specs but enabled only witness plugin: 15826 seconds