bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Store some data in ES as objects instead of just as strings #2565

Closed abitmore closed 2 years ago

abitmore commented 2 years ago

PR for https://github.com/bitshares/bitshares-core/issues/2380 and #1400.

The strings are kept for backward compatibility. The objects are stored redundantly in new fields with name (old_field_name)_object. The affected fields are listed below.

Note: more disk space is required for ES to store the redundant data. Here is some data for comparison. index old size new size
history-2015-10 81.9M 89.1M
history-2015-11 120.1M 146.5M
history-2015-12 133.4M 147.7M
history-2016-01 150.2M 166.1M

BTW https://github.com/bitshares/bitshares-core/issues/2568 is the next work to be done.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

63.8% 63.8% Coverage
0.0% 0.0% Duplication