bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Update cli_wallet to support unencrypted memo #2574

Open abitmore opened 2 years ago

abitmore commented 2 years ago

Description

It is possible to use unencrypted memo: https://github.com/bitshares/bitshares-core/blob/173ff3d27a4ca076a62bffdcd22d8f315b239a68/libraries/protocol/include/graphene/protocol/memo.hpp#L36-L37

However, cli_wallet does not support it (btw: code duplication).

https://github.com/bitshares/bitshares-core/blob/1f3e2e9b952f2978ef137bee60a9f6a7d9625571/libraries/wallet/wallet_sign.cpp#L181-L183

https://github.com/bitshares/bitshares-core/blob/23263b0e649ed657b79dd7168f046416d07cd9d0/libraries/wallet/operation_printer.cpp#L86-L88

Impacts Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

Additional Context (optional) Add any other context about the problem here.

CORE TEAM TASK LIST