bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

ElasticSearch related code refactory #2576

Closed abitmore closed 2 years ago

abitmore commented 2 years ago

Refactored code mainly in the sense of object-oriented programming.


BTW here is an interesting error during development. -_-!

.../elasticsearch.hpp:47:7: error: expected identifier before ‘(’ token
   47 |       DELETE  = 4,
      |       ^~~~~~

In Win32, DELETE is a macro used for dealing with ACLs (access control lists). (link)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

75.4% 75.4% Coverage
0.0% 0.0% Duplication