bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 649 forks source link

Add a new database API to get signed block header #2588

Closed abitmore closed 2 years ago

abitmore commented 2 years ago

User Story

As a client app developer I want a database API which returns the signed block header of a given block number (or perhaps multiple blocks) so that I can calculate the block ID without getting the entire block.

Additional Context (optional)

We have a get_block_header API but it does not return the witness signature thus unable to calculate the block ID with the result. The get_block API is usable, but it returns too much data.

Impacts Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.

CORE TEAM TASK LIST

abitmore commented 2 years ago

Perhaps update the existing get_block_header API to return the signature too?

By the way, the get_block_header_batch API is similiar.

abitmore commented 2 years ago

Done via #2641.

abitmore commented 2 years ago

Optimizing via #2652.

abitmore commented 2 years ago

Done via #2641 and #2652.