bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Extend get_block_header and get_block_header_batch APIs to return witness signatures #2641

Closed abitmore closed 1 year ago

abitmore commented 1 year ago

PR for #2588.

Update: this PR is superseded by #2652.

Note: the witness_signature field is a bit long, so the return size has increased.

Before:

{"previous":"00000004659ea6a0ae8928db63338ca9b16e4a70","timestamp":"2015-05-15T14:27:20","witness":"1.6.6","transaction_merkle_root":"3d1a3de0a1de97f7b300846e1f2ec5b0c84179e2","extensions":[]}

After:

{"previous":"00000004659ea6a0ae8928db63338ca9b16e4a70","timestamp":"2015-05-15T14:27:20","witness":"1.6.6","transaction_merkle_root":"3d1a3de0a1de97f7b300846e1f2ec5b0c84179e2","extensions":[],"witness_signature":"204e4172a77f89749e2a6a00eaf069c88dfb0ca2f985ba86c8f0b5a7e39d41b82953defea5805f510b83b40ef7f8ee11ad9f43a8a51ea72520a600bebd44a23534"}

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication