search

bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Fix code smells #2705

Closed abitmore closed 1 year ago

abitmore commented 1 year ago

Note: this is identical to https://github.com/bitshares/bitshares-core/pull/2703, recreated to get around a permission issue related to the sonar-scan Github Actions workflow.

rewind is reserved prefix increment dropped_count, i, next_block_num for efficiency increment from method call fetch_by_number() could cause undefined behavior parenthesis added for explicit operator precedence order of operations clarified max 1 nested break

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

60.0% 60.0% Coverage
0.0% 0.0% Duplication