search

bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 643 forks source link

Remove SonarCloud cache and threads configuration as it is now by default #2736

Closed mpaladin closed 1 year ago

mpaladin commented 1 year ago

No need to configure the cache and threads anymore, SonarCloud now has automatic analysis caching. See: https://docs.sonarcloud.io/advanced-setup/languages/c-c-objective-c/#analysis-cache.

abitmore commented 1 year ago

The Sonar-Scan workflow failed as usual at the last step (uploading results) due to permission issues (the workflow is unable to access the SONAR_TOKEN environment variable), see https://github.com/bitshares/bitshares-core/actions/runs/4512485037/jobs/7951321836?pr=2736

ERROR: Error during SonarScanner execution ERROR: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

I'm merging it into a new branch in the repository to make progress.

abitmore commented 1 year ago

Proceeding with #2737.