search

bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 648 forks source link

Improve worker query API #759

Open abitmore opened 6 years ago

abitmore commented 6 years ago

Some work has been done in https://github.com/bitshares/bitshares-core/pull/352, but seems we need to do more work. There is an UI issue related: https://github.com/bitshares/bitshares-ui/issues/1349.

Another UI issue: https://github.com/bitshares/bitshares-ui/issues/1352

oxarbitrage commented 6 years ago

it seems the UI went over this by the use of get_all_workers. Problem with this call is that it can became a performance issue in the future as it will just return ALL. apart from that i cant see anything else to improve based in the 2 UI issues.

abitmore commented 6 years ago

I guess I was thinking about pagination.

oxarbitrage commented 6 years ago

ok, we can add but we need to ask @svk31 to coordinate as they need to change the UI. @svk31 pls confirm you are ok with adding 2 params(start and limit) into get_all_workers, UI will need to make the call in a loop.

abitmore commented 6 years ago

We can make a new API then deprecate get_all_workers later. Low priority.