search

bitshares / bitshares-core

BitShares Blockchain node and command-line wallet
https://bitshares.github.io/
Other
1.17k stars 647 forks source link

Backport EOS patch about GELF 1.1 unstringified numbers #997

Open abitmore opened 6 years ago

abitmore commented 6 years ago

https://github.com/EOSIO/eos/commit/2d980b46a383f6cda346025cfbdc83185b7480ef

Note: I believe GELF logging is not used by default in BitShares, although node admins can try it.

Easy task but low priority.

jmjatlanta commented 6 years ago

https://github.com/EOSIO/eos/pull/2458

It seems that if GELF is set up to use udp, a network "would_block" error could needlessly cause problems. The PR above should have fixed it in EOS. We should look at doing something similar.

This may deserve its own ticket, but placing it here until more research is completed.

Update: Created issue #1005 to track the GELF/udp issues.

pmconrad commented 6 years ago

Related: https://github.com/EOSIO/eos/commit/b2be86055896d81fcffb88b9c992cacb3f9ddb44

pmconrad commented 6 years ago

Related to udp would_block: https://github.com/EOSIO/eos/commit/9224efeaa8e47a124996c8e8f849ecd1eb85b224