Order Book Improvements

wmbutler commented 6 years ago

The order book is a little busy. It's not really wide enough to warrant striped rows. Let's remove those. Also, if we can give a reference to the depth chart here with significant markers, it may remove the need for the depth chart toggle. This allows the user to have more information without toggling. This is a rough start and intended to spark discussion. I also noticed that most charting systems only show the size of the order for one side of the market.

I.e., if we are on BTS/USD, everything is priced in USD.

Notes

[ ] Gray tick Call Limit
[ ] Red Tick Settlement
[ ] Yellow Tick Margin Call
[ ] Bars are cumulative orders
[ ] Hovering over each bar makes it a stronger version of that color and also lights up the corresponding value in the Exchange Header.
[ ] Dark black background (hover state)
[ ] Entire area scrolls (not separate scrolling areas for bid and ask)
[ ] Only show order size (quantity) and price for one side of the market
[ ] Decimals but all be in line
[ ] Extra credit: dim gray for all insignificant leading and trailing zeros

vanissoft commented 6 years ago

Nice look, although big depth chart is a need. +1 to be priced in base asset.

fractalnode commented 6 years ago

we can not turn this large portion of information into such a small portion

info

wmbutler commented 6 years ago

We can still keep the toggle for the Market Depth. I won't use it, but no reason to get rid of the option.

abitmore commented 6 years ago

I don't think it's a good idea to remove the total value column from the order book.

It's very convenient for traders,
due to the implementation in core, prices showing on the book are usually inaccurate.

tbone-bts commented 6 years ago

I agree with @abitmore re: cumulative quantity column on the order book. It will be very inconvenient if you remove it.

wmbutler commented 6 years ago

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

screen shot 2018-01-28 at 1 34 29 pm

tbone-bts commented 6 years ago

Your screenshot shows three columns: (1) price (which for clarity should really be labeled bid/ask), (2) quantity of the asset being traded (in this case the quantity of BTS), and (3) price x quantity (i.e. total value of the bid or ask in terms of the base asset, in this case USD).

Also, you're looking at the vertical order book, which is ok for just watching a market...but not great for placing trades. The horizontal order book, on the other hand, has a 4th column displaying the cumulative running total of the value all bids (or asks) up to and including that row. That is very, VERY useful.

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

screen shot 2018-01-28 at 1 34 29 pm

wmbutler commented 6 years ago

This issue isn't proposing to make changes to the horizontal order book. Let's not confuse things. My points remain the same:

There is no cumulative value in the existing vertical order book
It's quite standard across exchanges to only display pricing in the purchase currency

abitmore commented 6 years ago

When you say "Total Value", what are you referring to? All I see is the asset quantity in each side of the trade. As far as cumulative quantity, that doesn't exist in the order book as you can see from this screenshot.

I mean the screenshot in OP shows only 2 columns. I like 3.

wmbutler commented 6 years ago

I'm not sure it makes sense to show 3. Looking across many different trading platforms, this is not accepted practice and I think it adds to confusion when new users hit our platform.

abitmore commented 6 years ago

Top crypto exchanges:

binance, showing 3: https://www.binance.com/trade.html?symbol=ETH_BTC
OKEx, horizontal layout, showing 2: https://www.okex.com/spot.html More others to be added here.

wmbutler commented 6 years ago

Point taken. Thanks.

[ ] Keep pricing in both assets.

abitmore commented 6 years ago

@calvinfroedge what's the progress so far? If you haven't started working on it, can you release it so I can ask @ety001 to work on it after finished #1106?

wmbutler commented 6 years ago

This needs to be worked on with @ahdigital as well. He is doing a full UX on the Exchange. #1449

abitmore commented 6 years ago

@wmbutler I feel that @ahdigital is overloaded, in the meanwhile we have quite some developers that can code now. Please prioritize things.

abitmore commented 6 years ago

Seems it has been implemented here: https://www.hellobts.com/market/BTS_CNY

wmbutler commented 6 years ago

It's close, but my concept is cumulative. Maybe we can borrow this code. Is it open sourced as well?

sschiessl-bcp commented 6 years ago

@startailcoon

Has this been picked up for your restyling? If not, I could evaluate after you are done and work out if anything should be added from here.

wmbutler commented 6 years ago

I submitted a proposed style as the first comment here. I like it because it allows the order book to serve two roles. @startailcoon would love to see where you end up with this.

MikhailKavalenka commented 5 years ago

@startailcoon , Do we only need to show the depth chart representation on the order book sections in vertical mode? Or the scope of the issue is more then that?

startailcoon commented 5 years ago

@MikhailKavalenka for me it would make sense to have this in the orderbook, regardless of position of it. So I would say it should be both cases.

bitshares / bitshares-ui

Order Book Improvements #1062

Notes