[2.5][twksos] Datetime picker Expiration - Calendar jumping and other behavior

[TechsUsInc]

Describe the bug From the Datetime picker:

1. The calendar jumps around randomly while scrolling through months/years.

2. Please see #2355 #2356 #2358

To Reproduce Steps to reproduce the behavior: Note that the jumping seems to be contingent on months that have 6 weeks while most have 5 (see screenshots)

1. Go to Exchange tab
2. Click on the BTS tab for BitCNY:BTS pair
3. Scroll down past the chart to buy/sell
4. Click on default expiration of 1 year
5. Click the default timedate shown noting a calendar popup
6. Attempt to click or scroll quickly through the months/years noting the calendar jumps around.

Expected behavior A clear and concise description of what you expected to happen.

1. After clicking the default expiration (1 year) the user should be able to open the calendar either way of clicking the currently shown datetime or clicking specific. The user should be able to quickly click or scroll through the months/years while the calendar remains stationary.
2. Consider moving the word "time" to the right closer to the time.
3. Consider adding a save (Done, or Close) button to the calendar as opposed to close on click of the selected date. Previous releases were close on click (I think). Adding a save button allows the user to modify the time if desired while the calendar is open (as opposed to closing upon clicking a date or year). For illustration

Screenshots

Desktop (please complete the following information):

• OS: Windows 8.1
• Browser Opera
• Version 56.0.3051.116
• Release 181212rc-1

Additional context I noticed while taking screenshots that if I clicked on the taskbar to open the snip tool OR anywhere else, the calendar would relocate. It prevented me from capturing the calendar shift but can be seen in the GIF capture.

[twksos]

request to work on this one

[twksos]

@startailcoon the 3 tasks in this story:

• make calender stationary done.

• move time close to right in pull request to bitshares/react-datepicker2

• save button in pull request to bitshares/react-datepicker2

This issue is blocked for now. I'll continue when the datepicker gets merged.

[startailcoon]

Awaits merging of https://github.com/bitshares/react-datepicker2/pull/2

@sschiessl-bcp can you merge this?

[sschiessl-bcp]

Someone should have mentioned that antd comes with a datepicker.

Can we switch to that one, and check if it provides everything we need. The [1] for adjusting the old one is ontop of course.

[sschiessl-bcp]

Could go hand in hand with checking #2358

[startailcoon]

When this issue was commented on I wasn't aware we had the DateTime-picker in the style-guide. We should have indeed used that.

AntD: https://ant.design/components/date-picker/ Style-Guide: https://styleguide.bitshares.org/

@twksos care to take a look at this with the style-guide DateTime-picker instead?

We'll increase the hours to accommodate the change. Since it's a new component, I'd say we could add another 1,5 hours for this task to be coded and checked.

[twksos]

@startailcoon will work on replace the DateTime picker

[twksos]

@startailcoon I just checked the latest code. Commits in #2356 has already applied new AntD date picker and the jumping around issue has gone with the old date picker.

[sschiessl-bcp]

Might have been a cross-issue resolution. Please state what efforts you had until now.