bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

Suggestion to abstract away IndexedDB requirement #2455

Open clockworkgr opened 5 years ago

clockworkgr commented 5 years ago

Right now, the UI depends heavily on IndexedDB being available using it as a live DB during normal operation (and not only for persistance).

This causes problems in browsers that disable IndexedDB access in private/incognito mode such as Firefox.

I suggest we use an in-mem abstraction for data storage during normal operation and only use IndexedDB or localStorage for persistence between sessions.

One option would be something like: https://github.com/agershun/alasql

clockworkgr commented 5 years ago

Would like input/thoughts from @startailcoon / @sschiessl-bcp / @gibbsfromncis and even @svk31 if he notices.

startailcoon commented 5 years ago

This sounds like a very good idea. We've had multiple instances in the past with users that have issues running the application in incognito mode or due to other browser specific issues.

However, AlaSQL states the following on their repository, making me wounder if it's really the best choice?

AlaSQL uses Semantic Versioning so please note that the major version is zero (0.y.z) and the API can not be considered 100% stable. Consider this before using the library in production and please check out the limitations of the library.

When we find a good alternative to how we do it today, there will be a few spaces to change the code, but it wouldn't be to difficult to do, but would require some extensive testing to make sure it works.

I assume that this would only apply to stored parameters, like settings, and not affect any stored wallet data.

sschiessl-bcp commented 5 years ago

Related https://github.com/blockchainprojects/bitshares-ui/issues/79

clockworkgr commented 5 years ago

Related blockchainprojects#79

cool. didn't realise it was already semi-being worked on

startailcoon commented 5 years ago

Bump