bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

[ahdigital][1] Enable creating a new committee member via GUI? #268

Open grctest opened 7 years ago

grctest commented 7 years ago

Similar to how recently the worker proposal system had GUI functionality added for the creation of worker proposals, perhaps it'd be worth enabling creating a committee member via the GUI so that more committee members (who may not be technically able to run a full/cli node) may have a chance at becoming a committee member? We've only got 11 committee members to vote from at the moment which isn't great.

Currently the only instructions on how to create a committee member is:

create_committee_member account "url" true

http://docs.bitshares.org/bitshares/tutorials/committee-member-create.html

sschiessl-bcp commented 6 years ago

pybitshares now supports this feature (https://steemit.com/bitshares/@xeroc/pybitshares-uptick-how-to-add-new-on-chain-features). Does bitsharesjs have any support for that @svk31 ?

svk31 commented 6 years ago

bitsharesjs supports all transaction types, it's just a matter of adding the functionality to the GUI.

wmbutler commented 6 years ago

Needs UX, @ahdigital ?

ahdigital commented 6 years ago

@wmbutler Assign me with a UX tag and I will come up with the UX/UI.

wmbutler commented 6 years ago

@ahdigital done

gibbsfromncis commented 6 years ago

@wmbutler @startailcoon can be assigned by me and @nikandrovalex? What do you think?

gibbsfromncis commented 6 years ago

@wmbutler @startailcoon I'll do careful review of scope of work later and provide my estimate or approve yours.

wmbutler commented 5 years ago

Still need UX. Can you churn this out? @nikandrovalex

gibbsfromncis commented 5 years ago

@wmbutler Alex is waiting to receive his first payment before continue our collaboration.

gibbsfromncis commented 5 years ago

@sschiessl-bcp can you provide a link with transaction's specification (new committee create)? I want to know what are the fields should be used for that

sschiessl-bcp commented 5 years ago

Create Operation https://github.com/bitshares/bitshares-core/blob/5b2309931c441412234c3bd09f39b41969c74dcc/libraries/chain/include/graphene/chain/protocol/committee_member.hpp#L37

Update Operation https://github.com/bitshares/bitshares-core/blob/5b2309931c441412234c3bd09f39b41969c74dcc/libraries/chain/include/graphene/chain/protocol/committee_member.hpp#L57

Only significant parameter is the URL

wmbutler commented 5 years ago

@nikandrovalex should have payments right?

clockworkgr commented 5 years ago

@gibbsfromncis you guys still working on this?

gibbsfromncis commented 5 years ago

@clockworkgr not right now. Should we unassign ourselves or pay more attention to this one?

clockworkgr commented 5 years ago

depends...if you have the UX or part of it done, we could possibly offer it to the community for the rest of it

gibbsfromncis commented 5 years ago

@clockworkgr I'll ask @nikandrovalex

startailcoon commented 5 years ago

Needs UX, open for claiming.

ahdigital commented 5 years ago

The feature UX could be as simple as adding a new button to the committee tab on the voting page:

image

Which, triggers a modal window:

image

sschiessl-bcp commented 5 years ago

The feature UX could be as simple as adding a new button to the committee tab on the voting page:

image

Which, triggers a modal window:

image

Should we create separate tasks for your UX that payment is faster?

ahdigital commented 5 years ago

@sschiessl-bcp

If that is no problem, yes please.

sschiessl-bcp commented 5 years ago

This is implemented now, but I forgot this issue ... let's use it for the UX payout (sorry @ahdigital I created a UX only bounty issue for another task and overlooked this one).

Can you please state your efforts for UX? The estimation [3] was meant for implementation for it iirc

image

image

image

sschiessl-bcp commented 5 years ago

Due to the refactoring and addition of witness, the bounty request is 5. Actual hours spent on coding this is 16.

ahdigital commented 5 years ago

UX is good for 1 hour. I saw a spelling mistake in the 2nd screenshot of yours.. "explaining why yo"

startailcoon commented 5 years ago

Set this issue for 1 hour, as requested by ahdigital for the UX. Sorry for the delay in updating this.