Open mindfulme opened 5 years ago
I have started updating the UI of the exchange tab, will post my progress here every day
Please consult with UI team first before diving in more.
The Exchange section is a huge part, which should be discussed before larger changes are made. We're interested in hearing any possible work, but please consult with the UI team, as noted by Stefan
I will, okay
Please consult with UI team first before diving in more.
I will start the discussion BitsharesDev telegram chat, Stefan already noticed the suggestion before - we will talk regarding that
First-day progress on Exchange UI Tab - it is just started will be better over several days
I think you can check: https://olddex.cybex.io/market/CYB_JADE.USDT
and this is the basic UI of binance which was more better than advanced: https://www.binance.com/en/trade/BTC_USDT
Bitshares has slow UI overall, so scrolling is better to remove at all, basic Binance exchange UI has scrolling generally so it is not that good solution for our case
@shulthz thx very much, we have found open source version of binance advanced exchange on cybex dex repository. They already copied 1-1 everything from binance. https://github.com/CybexDex/cybex-web-2.0
It works pretty fine with Bitshares nodes as well, we will do some magic on it to match bitshares color themes
en, that's nice
@shulthz Did you try to configure https://github.com/CybexDex/cybex-web-2.0 with Bitshares node.
@shulthz Did you try to configure https://github.com/CybexDex/cybex-web-2.0 with Bitshares node.
sorry about that
@shulthz Are you related to Cybex project?
@shulthz Are you related to Cybex project?
No
@MindfulMe are you refactoring or redesigning? Please note that this task has no approved estimate (yet).
Got it
I have merged their UI but there is some work to keep original bitshares-ui functionality on exchange tab
First-day progress on Exchange UI Tab - it is just started will be better over several days
Just FYI the layout doesn't work well on smaller screens. Please keep responsive design in mind.
@MindfulMe if your screen is big enough, perhaps your layout is better.
I think the best approach for this issue, is to add a new style, and show different default style on different detected screen sizes. Click "Personalize" at the top-right corner, you'll see what/how to add.
@MindfulMe if your screen is big enough, perhaps your layout is better.
I think the best approach for this issue, is to add a new style, and show different default style on different detected screen sizes. Click "Personalize" at the top-right corner, you'll see what/how to add.
Okay, I have rolled back to the original UI, Cybex-UI is not suitable for integration with bts-ui since it is highly slow, basic UI of cybex does not look that complex to copy though
I will preserve the original UI code with further updates to styles and the further stuff with preserving all bts functionality looking more conveniently for users
I would be sold on re-coding the whole thing with a nice clean reduced UX.
Have you checked the various gateway UIs how they are doing it?
There is already no scroll needs polishing on overall positioning of the rest of the components and tabs, styles, etc
I have not changed much, tried to do it as clean as possible. Stay tuned on further updates
I have not changed much, tried to do it as clean as possible. Stay tuned on further updates
Since we roll back from Cybex back to the version in which I have been modifying the original Bitshares-UI (Latest "develop" version)
On mobile looks decent
We are currently discussing redesign as well, please have a look at mobile design here #2854
Desktop design is following as well. Maybe you could implement that one then?
I have not changed much, tried to do it as clean as possible. Stay tuned on further updates
I'm curious to see what you are cooking up.
@startailcoon should we add a bounty for his investigations? Currently, this task is not in a Milestone or has an estimate.
I've been following your comments and progress. It doesn't have any bounty or milestone so far as I haven't seen it possible to refactor the whole thing, and we're still waiting for the new UI specs.
However, I do see some possible bounty for these testings, and with some help by the UI team, we could perhaps find a good optional layout that we could add as a "testing"?
Whatever, I will finish the version of Exchange tab and submit as a new branch. I guess in 3 days will be ready
Some polishing to the modals would be ok
Nice progress! Is it responsive for small screens too (not mobile / tiny)?
Is your feature request related to a problem? Please describe. The problem is that the Exchange Tab is highly inconvenient, especially scroll can't be used, the UX is very bad because of that. Describe the solution you'd like I suggest making the Exchange UI the same as on Binance (Advanced View). I will take care of the implementation
Describe alternatives you've considered I have considered updating the UI of the Exchange Tab anyway.
Additional context From this
To this