bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

[0.25][3.1.190618-rc2] HTLC - Problem with "Extend HTLC" #2868

Open allfory0u opened 5 years ago

allfory0u commented 5 years ago

Describe the bug When I want to extend HTLC and I click on "Expiration date - Two days" or "Expiration date - One week", I see the date changing from the current one to two days ahead or a week. But after updating the time of the HTLC action, I see that the value I specified was added to the previous value, and not replaced by it.

To Reproduce Steps to reproduce the behavior:

  1. Go to HTLC
  2. Click on 'Create HTLC'
  3. Fill out the forms
  4. Click on 'Create'
  5. Go to HTLC
  6. Click on 'Extend'
  7. Change the "Expiration date"
  8. Click on 'Update'

Expected behavior See changes in the value of "Expiration date" from "One day" to "Two days", and not the summation of these values. Or a more accurate description of this feature.

Screenshots Screenshot_10 Screenshot_11 yf0qzfWFn5 Screenshot_12 Screenshot_13

Desktop:

Additional context Not "Add seconds to claim period", but "Change seconds in claim period" Or change the description in the form of "Extend HTLC"

sschiessl-bcp commented 5 years ago

Ah .. yea that makes sense. Current logic is indeed "now + specified period" and not "current expiration date + specified period".