search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
517 stars 570 forks source link

Allow inverse input for Quantity/Total scaled orders #2877

Open froooze opened 5 years ago

froooze commented 5 years ago

Describe the bug The buying asset Quantity field and the buying asset Total field should have the inverted unit to fit the selling side.

To Reproduce Steps to reproduce the behavior:

  1. Go to Exchange Scaled orders
  2. Compare fields with portfolio unit

Expected behavior Use portfolio unit for order amount and the other unit for calculation of Total field. Buy Quantity field in BTS (input) and Buy Total field in bitUSD (output).

Screenshots scaled

startailcoon commented 5 years ago

I'm not really sure I understand what your idea is here. This is the same way, what I can see, as we do on the Limit tab.

On your screenshot you're Buying or Selling bitUSD. On the Buying side you're still buying a set of Quantity of bitUSD for a price for a total of BTS. Same on selling side, where you're selling a set of Quantity of bitUSD for a price for a total of BTS.

This is the same way as other exchanges does it. Can you please clarify?

froooze commented 5 years ago

@startailcoon : You are right it is the same as Limit Order and other Exchanges, but it doesn't make much sense to use the same form for the opposite task.

When I wanna buy bitUSD, I have to do this with a certain amount of BTS from my balance. Therefore the input value is BTS not bitUSD.

Quantity (input) and Total (output) should also be inverted for the opposite direction.

froooze commented 5 years ago

@startailcoon: I realized now, why I never complained about the wrong Limit Order form, because you can input in both fields your assets values and the scaled form only allows this in one way.