bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

Include "margin-calls" in Orders Column #2998

Open startailcoon opened 5 years ago

startailcoon commented 5 years ago

@sschiessl-bcp this does not view when a user is being margin called by being to low on collateral?

Example, take a look at https://develop.bitshares.org/#/account/abc.btsbots, which are being margin called at the moment, but it's still not visible on the users dashboard. We should make another issue to see if we can implement this as well I think.

There is also a bug when you click the asset that you settle, for example bitCNY. I'm settling 1 bitCNY for ~3 BTS. But clicking on bitCNY will display 1 BTS for 1 BTS.

Originally posted by @startailcoon in https://github.com/bitshares/bitshares-ui/issues/2755#issuecomment-514790993

Today we can view a users "Force Settlement", but a user that is force by a "Global Settlement" is not visible.

We should investigate the possibility to include this as well.

abitmore commented 5 years ago

@startailcoon I think your definition of "Global Settlement" is not the same as the commonly known one. Info about margin calls is in "margin positions" tab, if something is missing, should be added there.

startailcoon commented 5 years ago

@abitmore perhaps it is. What I mean is that when a user has a margin position that is collateralized by the market to settle its debt, it show up as a position on the orderbook. This does not show up on the users open orders, but is visible on the transaction history.

image

Perhaps my understanding isn't correct, please do tell if so, but I would wish this order #111380 to show up as an open order of some sort.

abitmore commented 5 years ago

image The CR 1.22 in red font means the debt position is in margin call status, so an amount of collateral could be bought at any time. The maximum amount that could be bought depends on TCR, debt amount, feed price and MSSR, perhaps we need to show it in the table. In addition, we can show the ID of the margin position (1.8.x) in the table. If you think showing something in the "open orders" page is better, it's also fair, but please don't use the "Global Settlement" term here.

By the way, I think we can improve the wording of "order #111380" a bit. If it's a limit order (1.7.x), it's fine to show it as "order #x"; but if it's a force-settle order(1.4.y) or margin position(1.8.z), it's better to show something different (see https://dev.bitshares.works/en/master/api/blockchain-objects-ids.html)

startailcoon commented 5 years ago

but please don't use the "Global Settlement" term here

Thanks for the clarification @abitmore , my bad here.

The only reason I think adding it to the open orders column is the fact that we added users personal settle orders there. We could add margin calls as well, if none thinks that's a bad idea. Improving the wording would be a good start.

froooze commented 5 years ago

In older client version margin call was on the exchange under open orders, this should be the case again.