search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

[1][react-cat] Market picker select nonexistent trading pair #3018

Open react-cat opened 5 years ago

react-cat commented 5 years ago

Describe the bug User have an ability to select nonexistent trading pair what causes crash of market picker

To Reproduce Steps to reproduce the behavior:

  1. Go to market
  2. Open market picker and select TESTBTSHKD as a first asset
  3. See that you can't open market picker anymore

Expected behavior User should have an ability to select trading pairs that can't be trade

Screenshots marketPickerBug

Desktop (please complete the following information):

sschiessl-bcp commented 5 years ago

Can it be that it's a prediction market asset?

startailcoon commented 5 years ago

It's a prediction market, you can see it by the trading pair design. Ordinary markets have a / while a prediction market has a :.

Could be that we need to update this to make it possible to change the pair on PM as well.

react-cat commented 5 years ago

@startailcoon @sschiessl-bcp I think we should do it, cause as for me, it was uncomfortable and confusing that after selecting this pair I could do anything and I need to manually remove pair from url and reload page to make market picker work again.

Anyone interested in this task ? If no one wants it, I could make it in 1 hour, but feel free to take it.

startailcoon commented 5 years ago

@startailcoon @sschiessl-bcp I think we should do it, cause as for me, it was uncomfortable and confusing that after selecting this pair I could do anything and I need to manually remove pair from url and reload page to make market picker work again.

Anyone interested in this task ? If no one wants it, I could make it in 1 hour, but feel free to take it.

Feel free to work on it :)

My only question is, should we make the user aware that they are on a Prediction Market and not an ordinary market pair somehow?

react-cat commented 5 years ago

@startailcoon Maybe we could make some popup that will appear when user first time select prediction market. This way we can warn user that it is a prediction market, give a link where he can read more about prediction markets and it's differences from ordinary and of course a checkbox "never show again".
This could be a solution in case if you decide that we need to aware user.

And I have a question, what is that ?) Appears only on prediction market page AwesomeScreenshot-wallet-bitshares-org--2019-08-13_8_50

sschiessl-bcp commented 5 years ago

That is the "borrow & sell" button for prediction markets. I guess no one bothered to check it for new styling :)

sschiessl-bcp commented 5 years ago

As for the header, I agree that the header should be the same. Please check what extra special cases are in the header. As far as I remember its "only" that it allows only one market order (PREDICTION ASSET : ITS BACKING)