search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

[1.25] Add copy plaintext feature for offline signing to Transaction Confirm #3020

Open sschiessl-bcp opened 5 years ago

sschiessl-bcp commented 5 years ago

https://github.com/bitshares/bitshares-ui/issues/2657#issuecomment-519824413

image

On the footer row, on the bottom left Add a Copy icon with text "Copy TX", which does exactly that. Add this copy button also to bottom left of the JSONModal image

sschiessl-bcp commented 5 years ago

@abitmore instead of a copy button we could also add a toggle that switches the view of the json modal to a textarea that contains the formatted json?

abitmore commented 5 years ago

Please redo the feature about raw JSON in the scope of #2657 which is relatively easier, and leave this issue for offline signing only which is much more complicated.

sschiessl-bcp commented 5 years ago

Please redo the feature about raw JSON in the scope of #2657 which is relatively easier, and leave this issue for offline signing only which is much more complicated.

I've removed beet from this issue

sschiessl-bcp commented 5 years ago

Would you rather have a switch button on the bottom left of the modal, or have a new modal popup with the plaintext @abitmore?

abitmore commented 5 years ago

Both are fine.

abitmore commented 5 years ago

@sschiessl-bcp I think it's better to design the ability to switch as a general feature, whenever there is a tree, the user can click a button to switch to a plain JSON text view. That said, add a button to the tree component, so we can use it everywhere. Is it possible?

startailcoon commented 5 years ago

@sschiessl-bcp I think it's better to design the ability to switch as a general feature, whenever there is a tree, the user can click a button to switch to a plain JSON text view. That said, add a button to the tree component, so we can use it everywhere. Is it possible?

I like this approach. We could have a button or toggle for this placed for the user to use to either view the JSON Tree, or a JSON string that should be possible to copy for other purposes. The JSON string could use the copy button component.