bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

[2.5][nikandrovalex][1][gibbsfromncis] UX Add support for recurring payments #30

Closed svk31 closed 5 years ago

svk31 commented 7 years ago

From @svk31 on December 29, 2015 7:10

Copied from original issue: cryptonomex/graphene-ui#639

gibbsfromncis commented 5 years ago

@abitmore Agree. Specify period will be a dropdown with the following options:

sschiessl-bcp commented 5 years ago

Your points above is the reason why Bill was so keen on having it integrated in the send Modal from a UX perspective (should still be it's own component to reduce code clutter).

Months don't have a fixed second representation, that's what abit means. A hint to the user should be enough in that matter until Taconators BSIP is pushed further.

gibbsfromncis commented 5 years ago

@sschiessl-bcp you got my vision of clear User Experience. if you want to put it inside Send Modal - common user won't understand how it works. I do not see the reason to make simple things more complicated. Anyway, my idea was to show my vision. If you want to make it complicated - lets ask Alex to integrate it somehow with Send Modal.

My idea was - Withdrawal permissions is a separate section like Assets Creation/Updating etc where user able to see all info he needs and manage it.

If you disagree please provide strict requirements and lets ask Alex to work on it

nikandrovalex commented 5 years ago

@sschiessl-bcp @gibbsfromncis and so, what should I do next? 😊

nikandrovalex commented 5 years ago

@startailcoon If it's ok, can I get paid? @sschiessl-bcp

nikandrovalex commented 5 years ago

I spent 2hr 33min

TheTaconator commented 5 years ago

The "monthly" option is tricky because the back end calculates periods in seconds only. Please either add a description about how the UI will implement it, or don't have that option.

Agree. @gibbsfromncis Until Core has a second version of recurring withdrawal operation, secular periods like months should be avoided unless a special description is added that defines how "month" will be interpreted.

Might discuss with Core Team about the availability of a second version.

TheTaconator commented 5 years ago

@abitmore what about the case if I want to create withdrawal permission for you and give a permission for myself to withdraw money from your account? Should we add "authorized from" input with ability to change it. And if currentAccount !== authorizedFrom (gibbs-from-ncis !== abit) we make a proposed transaction for you to give me a permission?

Yes. For currentAccount !== authorizedFrom, proposed transaction is necessary when the recipient or anyone else initiates the recurring authorization. Then giver will need to be notified about the request, and will need a way to review the request.

TheTaconator commented 5 years ago

Also @TheTaconator regarding "recurring send" or "recurring debit", that could be "send" from the user/employer that sets it up, and the ui displays the term "debit" to the person/employee at the receiving end (like the mobile wallet user) i'd think.

(like an employer that sends out some of their company token to all subscribed employees every month. some employers may send some or all of an employees wages as company tokens, and each employee may receive a differing amount of the company token that month, based on their wages for that month)

This can be an option. Be cautious that if employee forgets to withdraw during a particular month then that month's withdrawal opportunity is lost.

startailcoon commented 5 years ago

Closing UX issue, moving forward with UI implementation in #2457