search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
517 stars 570 forks source link

My open orders is empty in exchange page after switching market #3225

Open abitmore opened 4 years ago

abitmore commented 4 years ago

Describe the bug If a user has viewed settle orders E.G. in market BTS/bitCNY, then switching to a market that doesn't have settle orders E.G. in market BTS/GDEX.BTC, the "my open orders" tab will be empty since it still tries to show settle orders.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://wallet.bitshares.org/#/account/exchange.btsbots'
  2. Click on 'Exchange'
  3. Click 'BTS' tab in 'my markets'
  4. Click 'bitCNY' in the market list to view the bitCNY/BTS market
  5. Scroll down to 'my open orders / settle orders'
  6. Click 'Settle Orders'
  7. Click 'GDEX.BTC' in the market list to view the 'GDEX.BTC/BTS' market
  8. See an empty 'my open orders' tab

Expected behavior When "settle orders" tab disappears, UI should switch to 'my open orders' tab correctly.

When the UI decides one panel should be hidden, it should activate another panel in the same group.

Screenshots image

Desktop (please complete the following information):

Additional context I think I have submitted this issue before, but can't find it right now.

abitmore commented 4 years ago

Workaround for users when this happens: click the "my open orders" text then the orders will show.

froooze commented 4 years ago

@abitmore I could not reproduce this, maybe I have different default settings?

Does the problem still exist after this patch ? https://github.com/bitshares/bitshares-ui/pull/3194/commits/cbbeaf9fcd253d1b67611b9b44aa0e456692c78c

abitmore commented 4 years ago

Does the problem still exist after this patch ? cbbeaf9

I have no testing environment so can't test, sorry.

froooze commented 4 years ago

I have no testing environment so can't test, sorry.

You can also manually set to new default settings by cloning this:

image

abitmore commented 4 years ago

By default, settlements and open orders are in the same group. Thus the bug.

abitmore commented 4 years ago

IMO changing the default values only hides the bug, since users can update the settings, then the bug report will come again but just with more steps to reproduce. Ideally UI should make sure it always work with whatever settings.

froooze commented 4 years ago

@abitmore I agree here, but the exchange layout gets a rewrite, changing the default settings is only the first step.

froooze commented 4 years ago

https://github.com/bitshares/bitshares-ui/issues/2906

abitmore commented 4 years ago

As I understood layout rewrite is not in the roadmap.

froooze commented 4 years ago

As I understood layout rewrite is not in the roadmap.

at least on my roadmap

abitmore commented 4 years ago

IMHO the correct behavior should be: when the UI decides one active panel should be hidden, it should activate another panel in the same group. (OP updated)