search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 570 forks source link

The Exchange page does not display the market trades which were individual settlements or global settlements #3446

Open abitmore opened 2 years ago

abitmore commented 2 years ago

Describe the bug

The following data was got from the BTS/CNY market: image image image

API request

{"method":"call","params":[4,"get_fill_order_history",["1.3.113","1.3.0",200]],"id":60}

API response

{"id":60,"result":[{"id":"5.0.189530032","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951722},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":21892151,"asset_id":"1.3.0"},"order_id":"1.8.132367","account_id":"1.2.171572","pays":{"amount":766225310,"asset_id":"1.3.0"},"receives":{"amount":10044590,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":35156065,"asset_id":"1.3.113"},"quote":{"amount":"2605166054","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530031","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951721},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":195918,"asset_id":"1.3.0"},"order_id":"1.8.133141","account_id":"1.2.561774","pays":{"amount":6857140,"asset_id":"1.3.0"},"receives":{"amount":90000,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":78750,"asset_id":"1.3.113"},"quote":{"amount":5828569,"asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530030","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951720},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":397131322,"asset_id":"1.3.0"},"order_id":"1.8.131174","account_id":"1.2.441438","pays":{"amount":"13899596278","asset_id":"1.3.0"},"receives":{"amount":182645898,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"3196303215","asset_id":"1.3.113"},"quote":{"amount":"236293136726","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530029","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951719},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":179794293,"asset_id":"1.3.0"},"order_id":"1.8.131605","account_id":"1.2.385965","pays":{"amount":"6292800263","asset_id":"1.3.0"},"receives":{"amount":82714901,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"2895021535","asset_id":"1.3.113"},"quote":{"amount":"213955208942","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530028","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951718},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":598618581,"asset_id":"1.3.0"},"order_id":"1.8.132513","account_id":"1.2.7137","pays":{"amount":"20951650346","asset_id":"1.3.0"},"receives":{"amount":275479161,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"9641770635","asset_id":"1.3.113"},"quote":{"amount":"712356111764","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530027","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951717},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":446687393,"asset_id":"1.3.0"},"order_id":"1.8.132368","account_id":"1.2.17391","pays":{"amount":"15634058771","asset_id":"1.3.0"},"receives":{"amount":205626534,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"3598464345","asset_id":"1.3.113"},"quote":{"amount":"265778999107","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189530026","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951716},"time":"2022-01-23T19:45:00","op":{"fee":{"amount":116400839,"asset_id":"1.3.0"},"order_id":"1.8.133084","account_id":"1.2.461639","pays":{"amount":"4074029386","asset_id":"1.3.0"},"receives":{"amount":53600000,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":67000000,"asset_id":"1.3.113"},"quote":{"amount":"4947035683","asset_id":"1.3.0"}},"is_maker":true}},{"id":"5.0.189528937","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951715},"time":"2022-01-23T17:09:21","op":{"fee":{"amount":4113166,"asset_id":"1.3.0"},"order_id":"1.8.131605","account_id":"1.2.385965","pays":{"amount":143960819,"asset_id":"1.3.0"},"receives":{"amount":2000000,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":true}},{"id":"5.0.189528936","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951714},"time":"2022-01-23T17:09:21","op":{"fee":{"amount":0,"asset_id":"1.3.0"},"order_id":"1.7.488923685","account_id":"1.2.403172","pays":{"amount":2000000,"asset_id":"1.3.113"},"receives":{"amount":139847653,"asset_id":"1.3.0"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":false}},{"id":"5.0.189528935","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951713},"time":"2022-01-23T17:03:09","op":{"fee":{"amount":6169749,"asset_id":"1.3.0"},"order_id":"1.8.132368","account_id":"1.2.17391","pays":{"amount":215941229,"asset_id":"1.3.0"},"receives":{"amount":3000000,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":true}},{"id":"5.0.189528934","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951712},"time":"2022-01-23T17:03:09","op":{"fee":{"amount":0,"asset_id":"1.3.0"},"order_id":"1.7.488923578","account_id":"1.2.403172","pays":{"amount":3000000,"asset_id":"1.3.113"},"receives":{"amount":209771480,"asset_id":"1.3.0"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":false}},{"id":"5.0.189528933","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951711},"time":"2022-01-23T16:55:51","op":{"fee":{"amount":3084874,"asset_id":"1.3.0"},"order_id":"1.8.133084","account_id":"1.2.461639","pays":{"amount":107970614,"asset_id":"1.3.0"},"receives":{"amount":1500000,"asset_id":"1.3.113"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":true}},{"id":"5.0.189528932","key":{"base":"1.3.0","quote":"1.3.113","sequence":-21951710},"time":"2022-01-23T16:55:51","op":{"fee":{"amount":0,"asset_id":"1.3.0"},"order_id":"1.7.488923335","account_id":"1.2.403172","pays":{"amount":1500000,"asset_id":"1.3.113"},"receives":{"amount":104885740,"asset_id":"1.3.0"},"fill_price":{"base":{"amount":"2184471849137","asset_id":"1.3.0"},"quote":{"amount":"31240736512","asset_id":"1.3.113"}},"is_maker":false}},...

image

To Reproduce Steps to reproduce the behavior:

  1. Go to https://wallet.bitshares.org/#/market/BTS_CNY or https://develop.bitshares.org/#/market/BTS_CNY
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

abitmore commented 2 years ago

It is because that the trades were individual settlements which have only makers but no taker recorded with fill_order_operations, since the taker was the individual settlement pool. See https://cryptofresh.com/b/65694570. I guess the same applies to global settlements too.