bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
518 stars 569 forks source link

Tradingview for Charts #361

Closed malcolmjmr closed 6 years ago

malcolmjmr commented 7 years ago

screen shot 2017-10-07 at 12 49 56 pm

TradingView has probably the best charting functionality that I've used while trading crypto. It's really simple to use for novices and has all of the indicators and charting functionality that you would want if you are an experienced trader.

Currently, when trading on Bitshares I don't use the charts at all. It's not very usable. We need to integrate better charting libraries to retain more traders.

https://www.tradingview.com/HTML5-stock-forex-bitcoin-charting-library/

wmbutler commented 7 years ago

That is pretty slick. We are updating to the latest react charts this month. Maybe you can re-evaluate after 9/14 and see if there are any improvements. #350

svk31 commented 7 years ago

I like TradingView as well and have considered it on many occasions. I'm not sure we would get a license though, since we're not a traditional organization and the library will not be used on only one website but on any website running the BTS GUI. There's also an issue with respects to the documentation, which is only available to pre-approved users of their library.

wmbutler commented 7 years ago

I'll talk to them.

o5j5vg55bv5hv5j5f8799f9 commented 6 years ago

possibility additional charting tool demonstrating how to use it

permission thought bitshares.foundation

see another (sort of) dex platform using it image

wmbutler commented 6 years ago

Hi Bill,

The charting platform is perpetually free for any public use (including commercial). Don't worry! It's free, there are no fees.

You can grab the free charting platform here. Fill out all fields, sign and upload the provided form.

Best regards, Aziz J. Kenjaev Account Manager www.tradingview.com LinkedIn / Twitter On 06.10.2017 15:24:19, Bill Butler bill@butler.net wrote:

If we add the tradingview charting capability to the dex product, will there be monthly fees to account for? How does your billing work? Since none of us directly derives revenue (other than investment in the bts token) would you put bts in a category of non profit and waive fees?

These are the types of questions that keep us from moving forward with implementing.

Thanks so much for your time.

Sincerely,

Bill Butler

On Fri, Oct 6, 2017 at 7:17 AM Aziz J. Kenjaev aziz@tradingview.com wrote: Hi Bill,

Thanks for reaching out!

Please share your concerns and we will discuss them.

Best regards, Aziz J. Kenjaev Account Manager www.tradingview.com LinkedIn / Twitter

From: Bill Butler bill@butler.net Date: 10/5/2017 7:03:55 PM Subject: Bitshares DEX Inquiry To: founders@tradingview.com

Mr. Bokov,

My name is Bill Butler and I am heading up a UX rewrite for the Bitshares Distributed Exchange. We are interested in incorporating the TradingView library into the DEX. We believe it will solve many issues that we have on our exchange pages and will provide significant benefits to our user base.

Bitshares is a cryptocurrency whose function is to act a Decentralized Exchange. It is based on a high-performance graphene blockchain and has been around since 2012-2013.

There are some underlying concerns about licensing and how this might be handled. We do have resources and governance that would allow us to pay for the use of trading view. We are also open to any other arrangements that you might suggest.

Thanks for your time.

Sincerely,

https://bitshares.org

leandrovaldez commented 6 years ago

this is a really powerfull feature to improve the UI of bitshares, it's a must to get the real and usefull tools to drawing for TA

calvinfroedge commented 6 years ago

Has anyone downloaded the source package and confirmed the code can be implemented all client side? Want to be sure this doesn't involve adopting a backend as well.

vanissoft commented 6 years ago

I'm concerned about the TV integration as it may means a servitude towards external agents.

wmbutler commented 6 years ago

@calvinfroedge go ahead and spend time on this and I'll credit research hours to you.

svk31 commented 6 years ago

@wmbutler I don't think this offers depth charts, so the current depth charts will have to remain and issues related to them should stay open.

calvinfroedge commented 6 years ago

@wmbutler I will download the source code for TradingView and check it out

calvinfroedge commented 6 years ago

I have officially requested access to the source code and am awaiting acceptance. Time spent so far: 0.25 hours.

wmbutler commented 6 years ago

Any word yet?

calvinfroedge commented 6 years ago

Moved this to the research ticket. #774

wmbutler commented 6 years ago

OK,

Hoping to get some feedback from others here. Thanks for your work. Please put the appropriate hours in the header.

masalai585 commented 6 years ago

Having the settled and open orders on the chart ala Coinigy is so important for frequent trading. I still dont do regular day trading on Bitshares or Binance due to them missing on chart order display. Also regarding tradeview , a guy i was talking to on a slack channel made this nice little project https://www.multicoincharts.com/ Im guessing the problem with tradeview is going to be having all of the assets on their database, unless you can somehow add your own.

smogm commented 6 years ago

Would be nice to have this implemented as soon as possible!

wmbutler commented 6 years ago

Still looking for a volunteer. Wrapper is wriiten and ready to go.

smogm commented 6 years ago

@wmbutler what are the steps that have to be done? Just placing the widget into the page layout and feeding it with data?

wmbutler commented 6 years ago

We have the UDF wrapper. I'm not sure how complex it will be but I assume there are a number of things that could present problems. If you want to see how it's been incorporated already with bts feeds and the UDF wrapper, take a look at this:

http://bitshares-explorer.io/#/markets/CNY/BTS

svk31 commented 6 years ago

Cool, I didn't realize he'd already implemented it. I guess I'll have a crack at it then, we're also dependant on replacing stockcharts for react-16 compatibility so it'll be nice to get this done.

smogm commented 6 years ago

@svk31 Would be a really huge improvement if you could implement it! The current chart feature is the most annoying part of the gui.

Keeping my fingers crossed!

wmbutler commented 6 years ago

The issue is technically #905 This is just tracking all the work required thus far.

startailcoon commented 6 years ago

Issue #905 has been closed, expiring this issue tracker.

sschiessl-bcp commented 5 years ago

How can we reproduce it?

TechsUsInc commented 5 years ago

@sschiessl-bcp openexplorer_capture openexplorer_2-capture


        var a = !0
          , b = this;
        this.debugEnabled = function(b) {
            return r(b) ? (a = b,
            this) : a
        }
        ,
        this.$get = ["$window", function(c) {
            function e(a) {
                return a instanceof Error && (a.stack ? a = a.message && -1 === a.stack.indexOf(a.message) ? "Error: " + a.message + "\n" + a.stack : a.stack : a.sourceURL && (a = a.message + "\n" + a.sourceURL + ":" + a.line)),
                a
            }
            function f(a) {
                var b = c.console || {}
                  , f = b[a] || b.log || m;
                a = !1;
                try {
                    a = !!f.apply
                } catch (g) {}
                return a ? function() {
                    var a = [];
                    return d(arguments, function(b) {
                        a.push(e(b))
                    }),
                    f.apply(b, a)
                }
                : function(a, b) {
                    f(a, null == b ? "" : b)
                }
            }
            return {
                log: f("log"),
                info: f("info"),
                warn: f("warn"),
                error: f("error"),
                debug: function() {
                    var c = f("debug");
                    return function() {
                        a && c.apply(b, arguments)
                    }
                }()
            }
        }
        ]
    }```