Closed wmbutler closed 7 years ago
Updated the Margin positions UX to allow for all the math to add up. Of note:
Here's a testnet example with an account holding margin positions backed by something other than TEST (the core asset):
Order expiration just takes so much space I'm opposed to including it.
The 100% height on the black background requires a lot of messing around with css, I wasn't able to figure it out and not sure it's worth it.
No idea what you mean by narrow fonts in the header.
I used to have n/a for unknown prices, but nobody understood what that meant so I changed it..
The gap in the portfolio is between assets you actually have and the default list of assets that are shown so you can easily buy or trade them, they're shortcuts basically.
--
? I'll defend the decision.I know it feels like I'm being really picky at this point, but it's my hope that we can set as many standards now as possible on these tables. Please increase the hours on this items to reflect your time worked.
The sort order is by price, which is the only sorting that makes sense.
Hrmmm, open orders being sorted on price? I would think grouped by market and then date makes more sense. The sort order should not change when switching the pricing pair. I hope you take some time to reconsider your opinion here.
By markets first, then price.
My fear is that when someone inverts the price, they will lose whatever row they might have been on and may end up canceling the wrong order.
The market direction is persistent and consistent with your selection everywhere else, so I don't see why anyone would ever switch that direction more than once anyway.
Sorting by price makes it look similar to a vertical orderbook, which at least to me makes a lot of sense..
Current
Expected
I think this is about ready now, it's also taken a lot more time than the original estimate, at least 3 full days or 24 hours.
I figured!
In a portfolio view, it makes the most sense for your largest positions to be at the top, smallest at the bottom. So sorting descending by Value (not by Price) would really be best here.
Sorting by price makes it look similar to a vertical orderbook, which at least to me makes a lot of sense..
@tbone-bts we are cutting off the features for now. This falls under sort order. Open a separate issue for allowing sortby. Thanks.
I agree that allowing sortby is a different issue. But I was talking about the default sort order. @svk suggested default sort order should be by Price bc it's similar to order book...and I was pointing out that in a portfolio it should be sorted descending by Value of the holding.
We were talking about open orders, not the portfolio.
I agree it makes sense to sort the portfolio by value of the holdings, I'll have a look to see how difficult it would be to implement.
Ah ok, your comment was directly after a post with an image of the Portfolio table. Threw me off. But thanks for clarifying!
Merged
The idea behind a tables rewrite is to change the look without worrying too much about functionality. This amounts to a facelift while establishing some best practices for the future. The wallet has a somewhat haphazard approach to accessing certain features. Some items are in a top menu and others are on a side menu. Side menus are notorious for wasting horizontal space. I think they should go away ultimately, but don't want to change so much at once that it confuses users. With that in mind, I'm going to submit a table concept for the Overview page. As you can see, I've suggested that we call it Dashboard instead.
Rather than the user scrolling down and accessing other menus to get to other areas, I've created pills at the top. Areas that contain balance detail also display the total balances in the pill for a glance.
You should notice that the functionality of the table is identical but instead of clickable text, we have meaningful icons. I have also created separate columns for symbols and quantities so our data lines up in a more pleasing way.
As you view this, realize that the top and side menus aren't visible in my mockup. This table would be displayed in place of:
As we get closer to consensus, I also need to propose a light themed version of this.