search

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
517 stars 570 forks source link

[3][fletchertyler914] Feature Request: Offline Signing #776

Open abitmore opened 6 years ago

abitmore commented 6 years ago
  1. The online wallet generate a transaction, json format, need: a. TaPoS header, b. not-too-soon expiration time, c. required keys / signed keys (optional) d. serialized (optional)
  2. user copy the json to offline wallet, add signature
  3. user copy the signed transaction json to online wallet, broadcast

PoC:

fletchertyler914 commented 6 years ago

I will probably take this one @wmbutler

abitmore commented 6 years ago

Please keep in mind about how to deal with memo encryption.

fletchertyler914 commented 6 years ago

@abitmore, could you please explain exactly what you are looking for here as a reference point? Are you wanting to be able to do this for all transactions or just specific ones?

I'm trying to figure out of "Offline Transactions" needs its own space/page or if it should be added to the activity page. How are you envisioning the flow of the process in the current wallet UI?

fletchertyler914 commented 6 years ago

@abitmore: Additional insight would be necessary to complete this task.

abitmore commented 6 years ago

I don't have a clear definition right now.

sschiessl-bcp commented 6 years ago

Is this still desired?

abitmore commented 6 years ago

Yes.

clockworkgr commented 5 years ago

@abitmore will something like Beet integration cover the reasons why this was requested or do you still need the ability to sign on a separate air-gapped machine?

abitmore commented 5 years ago

I don't really need it, just think offline-signing is a good-to-have feature.

christophersanborn commented 5 years ago

This is how I currently sign transactions with the Ledger Nano app, except via the cli_wallet. But basically the same procedure described above: Create transaction, export JSON, edit expiration date, send to Nano, get signature, add sig to JSON, strip whitespace so I can import back into cli_wallet, import into cli_wallet, broadcast.

This would definitely be a useful UI feature, although perhaps primarily for hacker/tinkerer/advanced user types.

If the UI wallet adopted Beet integration, it might lessen the need for this feature, as Beet could perhaps be the front end to the Nano. But I think it would still serve a need for oddball/tinkerer use cases.

clockworkgr commented 5 years ago

Thanks guys. It's been a year and a half so I'll ping @fletchertyler914 first to see if he wants to wrap this up, other wise I'll make it claimable again.

@fletchertyler914 what info were you missing to complete this?