[4] Scan QR Code - Send Modal

bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain

https://wallet.bitshares.org

MIT License

518 stars 570 forks source link

[4] Scan QR Code - Send Modal #832

Open startailcoon opened 6 years ago

startailcoon commented 6 years ago

As we add more QR codes in the wallet I think it is about time we implement a component for accessing the camera on the users device to enable scanning.

This would add yet another safeguard on transactions for users.

startailcoon commented 6 years ago

Found a repository that does native react QR and barcode scanner. This may be worth looking at for a starting point.

https://github.com/moaazsidat/react-native-qrcode-scanner

wmbutler commented 6 years ago

Nice, which milestone should we shoot for?

startailcoon commented 6 years ago

I can take this for a milestone in the end of February, say 1st of March.

wmbutler commented 6 years ago

That's awfully far out. Could we shoot for Feb 15? That's technically my last day for this, unless the the next WP gets renewed.

startailcoon commented 6 years ago

Sure, lets set that date and I'll aim for a completion of it at that time.

wmbutler commented 6 years ago

180215

startailcoon commented 6 years ago

@svk31 can you help me import these two dependencies for this to work? I'm a little uncertain on the correct procedure on how to add dependencies.

https://github.com/lwansbrough/react-native-camera https://github.com/moaazsidat/react-native-qrcode-scanner

wmbutler commented 6 years ago

Breaking this into a few issues.

wmbutler commented 6 years ago

We are developing a bitshares-pay repo that will be the basis for accepting payments via bitshares assets of any kind. Please refer to this as you determine how to interpret a BTS compatible QR code:

https://github.com/bitshares/bitshares-pay/issues/1

abitmore commented 6 years ago

The QR code should be compatible with https://github.com/bitshares/bitshares-ui/issues/775#issuecomment-350202771

wmbutler commented 6 years ago

Agreed.

gibbsfromncis commented 6 years ago

@startailcoon I'll work on library install. Let me finish it in 2 days. If something be wrong I'll report you asap.

startailcoon commented 6 years ago

Pushed as it depends on library installs to be completed first

startailcoon commented 6 years ago

I will most likely have to push this for the next milestone due to the Gateway integration. If anyone wish to claim it, do tell me and I'll hand it over.

gibbsfromncis commented 6 years ago

@wmbutler please answer the following questions:

What is the format of URI (encoded in QR) which user should be able to scan?
Should this feature be duplicated on transfer page?

wmbutler commented 6 years ago

@gibbsfromncis this is definitely an unknown with several opinions. Before we can have a send function, I suppose we need a receive QR code to scan. And we really don't have a "receive" function in bitshares other than "deposit" which doesn't quote apply to this situation.