bitshares / bitshares-ui

Fully featured Graphical User Interface / Reference Wallet for the BitShares Blockchain
https://wallet.bitshares.org
MIT License
517 stars 570 forks source link

[5.5][dot5enko] Exchange Header #888

Closed wmbutler closed 6 years ago

wmbutler commented 6 years ago

We are planning to integrate TradingView for the charting, but I wanted to go ahead and submit a UX for the header which includes how we will display key metrics. This will help tradingview integration to at least have a design to draw inspiration from. I stole this look from GDAX largely. Principle changes over our existing layout allow for a full row of information without letting the order book cut into the left edge. The new design also stresses large information with small labels.

Current

screen shot 2017-12-20 at 10 28 04 pm

Proposed

screen shot 2017-12-20 at 10 20 25 pm

dot5enko commented 6 years ago

@wmbutler i claim this. Arrow in the latest price block is quite informative, do you really want to remove it? maybe we can make it like 24h price - with appropriate colors?

Xeldal commented 6 years ago

suggestions: 1) replace "24 hour price" with "24 hour change"

2) anywhere there is a "price" (ie "settlement price") where we currently list the quote over the base (ie bitUSD/BTS). I suggest only listing the quote (ie bitUSD) like you have in the example for "latest trade price". I haven't check every exchange in the universe but I haven't found a single one that lists the full fraction (quote/base). A couple reasons come to mind. A trading pair is listed BASE/QUOTE, if on the same page you're seeing lots of the opposite arrangement(ie QUOTE/BASE) like you do on our exchange. It can be confusing as to whether you have the exchange oriented the right way or if its flipped. Another reason is that the price of something almost always presumes that the base = 1 and so the full fraction isn't necessary.

The price is how much of the QUOTE currency is necessary for 1 of the BASE.

so: old-> Settlement Price = 0.640118 bitUSD/BTS new-> Settlement Price = 0.640118 bitUSD

The same should be applied throughout the entire exchange page.

wmbutler commented 6 years ago
dot5enko commented 6 years ago

ok. start working

wmbutler commented 6 years ago

@wmbutler i claim this. Arrow in the latest price block is quite informative, do you really want to remove it? maybe we can make it like 24h price - with appropriate colors?

wmbutler commented 6 years ago

@dot5enko can you have this completed by Jan 4?

dot5enko commented 6 years ago

@wmbutler i'm working on it whole day. Still have few issues, try to accomplish them today

wmbutler commented 6 years ago

Happy to increase the hours if needed.

dot5enko commented 6 years ago

@wmbutler would be great if we can add two hours here.

wmbutler commented 6 years ago

Done. Any progress? Would love to see some screen shots. Also wanted to make sure that the div goes all the way across which would push My Market / Find Markets down as well.

dot5enko commented 6 years ago

@wmbutler hm... i haven't seen that from your screen shot, so now its only pushes chart and order list. But seems it would be not that hard to meet your requirements. This is the current state of header. Trying to complete it today

image

dot5enko commented 6 years ago

@wmbutler not yet ready with price pulsation and market depth/chart switch button image image

wmbutler commented 6 years ago

Looking awesome

dot5enko commented 6 years ago

yup, they're all stylized in that way: settle price, margin call prices. i'll try to make screenshota with all of them

wmbutler commented 6 years ago
dot5enko commented 6 years ago

image @wmbutler how about this border? i got color from bottom of "my markets"

wmbutler commented 6 years ago
dot5enko commented 6 years ago

ok. no problem)

dot5enko commented 6 years ago

image

wmbutler commented 6 years ago

Schwing!

dot5enko commented 6 years ago

forget to make a screenshot with margin call price on it. Here is a simulated behaviour with appropriate colors: image/ Got it. Prices are crazy today! image

dot5enko commented 6 years ago

@wmbutler check last modifications

Volume asset change on click: volume

stats pulsation (look at a latest price): pulsation

If everything is ok, i'll make a PR