Wallet scaning is possibly triggered while upgrading - Githubissues

bitshares / bitshares1-core

Software to run the old chain (before 2015-10-13). Code for current chain is https://github.com/bitshares/bitshares-core

https://bitshares.org/

The Unlicense

219 stars 174 forks source link

Wallet scaning is possibly triggered while upgrading #1544

Closed abitmore closed 9 years ago

abitmore commented 9 years ago

Before upgrading a wallet, it need to be unlocked first,

_wallet_password is set to a value here: https://github.com/BitShares/bitshares/blob/edf9b381284b8abf8eedf1a58f92a0bbb03d82ee/libraries/wallet/wallet.cpp#L1179 thus wallet_impl::is_unlocked() will return true
when the client receives a new block, wallet_impl::block_pushed() will call start_scan() : https://github.com/BitShares/bitshares/blob/edf9b381284b8abf8eedf1a58f92a0bbb03d82ee/libraries/wallet/wallet.cpp#L37

Since the wallet is in an insistent state while upgrading, scanning at the same time may cause trouble.

abitmore commented 9 years ago

I was wrong. wallet_impl::block_pushed() won't execute while upgrading wallet.