search

bitshares / bitsharesjs

JavaScript tools for BitShares Encryption and Serialization
https://bitsharesjs.bitshares.org/
MIT License
96 stars 149 forks source link

ChainValidation.is_valid_symbol_error("A.ABC")) returns null #80

Closed freak5g closed 3 years ago

freak5g commented 3 years ago

Should throw error or I'm wrong? https://github.com/bitshares/bitsharesjs/blob/db009153e4f0bfaf04e43db393b3aa45f6de72ab/lib/chain/src/ChainValidation.js#L115

abitmore commented 3 years ago

I think it should throw. But perhaps it does not matter, because you need to own A to be able to create A.ABC, but A is not valid.

freak5g commented 3 years ago

Yes, you're right, it doesn't matter. It is for one particular use case only.