search

bitshares / bsips

BitShares Improvement Proposals and Protocols. These technical documents describe the process of updating and improving the BitShares blockchain and technical ecosystem.
https://bitshares.github.io
63 stars 86 forks source link

BSIP73: Match force-settlement orders with margin calls and limit orders #200

Closed abitmore closed 4 years ago

abitmore commented 4 years ago

PR for #181.

pmconrad commented 4 years ago

Thanks. FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

abitmore commented 4 years ago

Thank you @pmconrad. The "Summary for Shareholders" section is still "TBD", I hope someone can help.

pmconrad commented 4 years ago

Suggested summary:

When force-settling a SmartCoin, the user currently has to wait for the settlement delay before his tokens are exchanged for the collateral asset. This BSIP introduces a new flag that allows settlement requests to be matched with market orders during the waiting period, potentially resulting in faster settlement and a better price.

abitmore commented 4 years ago

@pmconrad thanks. Please review again.

sschiessl-bcp commented 4 years ago

FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

Should this be incorporated in the summary, or do we rather not burden the voters with this technical aspect?

abitmore commented 4 years ago

FTR, my approval only means that I think this BSIP meets formal requirements. I still think it does not add sufficient value to justify the cost (performance impact, more complicated market engine, implementation cost).

Should this be incorporated in the summary, or do we rather not burden the voters with this technical aspect?

Create a PR please? Thanks. I'll do it.