search

bitshares / bsips

BitShares Improvement Proposals and Protocols. These technical documents describe the process of updating and improving the BitShares blockchain and technical ecosystem.
https://bitshares.github.io
63 stars 86 forks source link

Update PR 115 (BSIP48) modify_max_supply #216

Open jmjatlanta opened 5 years ago

jmjatlanta commented 5 years ago

This PR will adjust the language and add a few details to PR #115 to hopefully clarify the desires of the BSIP.

abitmore commented 5 years ago

Also there is a discussion in https://github.com/bitshares/bitshares-core/pull/1375 about adding a disable_issue flag, perhaps also add it in this PR?

And maybe https://github.com/bitshares/bsips/issues/187?

abitmore commented 5 years ago

Perhaps address #96 in this BSIP as well?

jmjatlanta commented 5 years ago

Perhaps address #96 in this BSIP as well?

I don't mind the extra work, but I feel this BSIP is already larger than the original. Do you feel the specifications of #96 were discussed enough that including it in this PR will not cause delays while details are hashed out?

abitmore commented 5 years ago

Do you feel the specifications of #96 were discussed enough

IMHO #96 is clear. Thanks.

ryanRfox commented 5 years ago

I agree #96 is clear by now. However, I prefer to have it drafted as a distinct BSIP, rather than bundled with this one. @jmjatlanta are you willing to assist with drafting that BSIP, else I can find another resource to do so.