bitshares / bsips

BitShares Improvement Proposals and Protocols. These technical documents describe the process of updating and improving the BitShares blockchain and technical ecosystem.
https://bitshares.github.io
63 stars 86 forks source link

BSIP 75 - Asset Owner defines MCR and MSSR values #218

Closed jmjatlanta closed 4 years ago

jmjatlanta commented 5 years ago

See Issue #96

abitmore commented 4 years ago

I wonder why this hasn't been merged.

abitmore commented 4 years ago

I got a better idea about specification and implementation lately: just add new optional value fields in bitasset options, which can be updated by the asset owners:

struct bitasset_options 
{
   //...
   optional<uint16_t> mcr;
   optional<uint16_t> mssr;
   optional<uint16_t> icr;
};

If one of the parameter is set, it means the owner has an opinion on the parameter and it will be in effect; if not set, then the value provided by the feed producers will be in effect.

We can assign a permission bit on each parameter too, so the owners can decide whether to forfeit the right to update it.

MichelSantos commented 4 years ago

We can assign a permission bit on each parameter too, so the owners can decide whether to forfeit the right to update it.

I proposed a commit to include permissions. I left out references to ICR because I thought that it might be out of scope. If appropriate I have text which to update BSIP77 with a similar discussion about permissions.

abitmore commented 4 years ago

Yes I think BSIP77 can be updated similarly. Thanks.