search

bitshares / bsips

BitShares Improvement Proposals and Protocols. These technical documents describe the process of updating and improving the BitShares blockchain and technical ecosystem.
https://bitshares.github.io
63 stars 86 forks source link

BSIP77: Require Higher CR When Creating/Adjusting Debt Positions #226

Closed abitmore closed 4 years ago

abitmore commented 5 years ago

PR for #161.

bitcrab commented 4 years ago

if no more change required, possible to merge this ASAP?

sschiessl-bcp commented 4 years ago

I am wondering if this might need to be reconsidered?

Note: logic around *target collateral ratio* (TCR) is not affected.

Current BSIP only affects initial positions. It is to be expected that positions live longer such that replenishing CR through margin call would happen more often as compared to creating a new position. Essentially, my suggestion is to also enforce ICR as minimum value for TCR (no new parameter). Could have a boolean flag to switch this on if owner desires it.

It was discussed here but not till the end I believe.

abitmore commented 4 years ago

Current BSIP only affects initial positions.

No, it affects updating of existing positions as well.

sschiessl-bcp commented 4 years ago

Current BSIP only affects initial positions.

No, it affects updating of existing positions as well.

Yes, of course. I think automatic mechanism of the platform should also honor the asset owner desired buffer.

bitcrab commented 4 years ago

I am wondering if this might need to be reconsidered?

Note: logic around *target collateral ratio* (TCR) is not affected.

Current BSIP only affects initial positions. It is to be expected that positions live longer such that replenishing CR through margin call would happen more often as compared to creating a new position. Essentially, my suggestion is to also enforce ICR as minimum value for TCR (no new parameter). Could have a boolean flag to switch this on if owner desires it.

It was discussed here but not till the end I believe.

in my view it is good to limit TCR>=ICR, although it is not a must.