search

bitshares / bsips

BitShares Improvement Proposals and Protocols. These technical documents describe the process of updating and improving the BitShares blockchain and technical ecosystem.
https://bitshares.github.io
63 stars 86 forks source link

New BSIP: Escrow Services #44

Open abitmore opened 6 years ago

abitmore commented 6 years ago

Details to be worked on.

Related discussions: https://bitsharestalk.org/index.php/topic,23800.0.html https://bitsharestalk.org/index.php/topic,24155.0.html

xeroc commented 6 years ago

I can help out technically on this one. A year ago, I wanted to setup peermit.com which is like bitgo, but for bitshares. Couldn't finish it up due to legal issues in Europe with escrow in general. Tech ist still there

abitmore commented 6 years ago

As mentioned in one of the above posts by "Bangzi":

This feature is very powerful to run web site like LocalBitcoin and localEthereum. After some research, I found that there is Escrow Operations code in STEEM, another graphene project. Perhaps core developers can look into this.

  1. Add Escrow Operations in STEEM by BM https://github.com/steemit/steem/issues/143 https://steemit.com/sip/@dan/escrow-sip-steem-improvement-proposal

  2. Open Source STEEM Escrow GUI https://steemit.com/utopian-io/@reazuliqbal/opensource-steem-escrow-gui https://steemit.com/escrow/@xtar/open-source-standalone-gui-for-steem-escrow-transactions

oxarbitrage commented 6 years ago

i was checking this and i actually think that if we follow what steem did, following step by step their commits up to where @abitmore improved it should be not very hard to add the same escrow features to bitshares.

i am wondering how successful this approach is for steem and how much value it can add for our blockchain.

if we agree that we are going to follow what steem did i can write the bsip and (if approved) work on it for the next hardfork release.

abitmore commented 6 years ago

@oxarbitrage Steem has no UIA so far, although they'll have SMT's soon. Also, their user base is different. So use case of this feature in Steem is limited. Of course we can copy it, but I think we can do better, anyway we need a BSIP first. I think it's too tight to finish it before next hard fork release (around May 2018).

oxarbitrage commented 6 years ago

i see, we definitely want to include UIAs if possible. also @xeroc seems to be open to something more generic with https://github.com/bitshares/bitshares-core/issues/692 i toke a look into that, don't fully understand it yet.

i think this is important, we can start with a draft bsip following steem while we add the feature to UIAs.

it might be too tight for the next hardfork but if you agree i can start writing the bsip.

abitmore commented 6 years ago

I think pull request https://github.com/bitshares/bsips/pull/76 is for this issue.

oxarbitrage commented 6 years ago

relating with https://github.com/bitshares/bitshares-core/pull/866

abitmore commented 6 years ago

Assigned number 40 to this BSIP.