search

bitshares / open-explorer

Open Source BitShares Blockchain Explorer
https://open-explorer.io
MIT License
20 stars 41 forks source link

committee members active list #31

Open oxarbitrage opened 6 years ago

oxarbitrage commented 6 years ago

need to use http://open-explorer.io/#/objects/1.2.0 for the active committee members, all the rest is inactive.

oxarbitrage commented 6 years ago

@clockwork can you remind me how was this issue, i think you reported it to me iirc.

chris4210 is out of the top 11 by votes but he is in the committee_account object.

please explain how it can happen.

clockworkgr commented 6 years ago

I was actually planning to submit a PR each to the python backend and the open-explorer repos for both the witness and committee lists. The fix being that the python backend uses the active authority lists from witness-account and committee-account to get the number and IDs of the active members and uses that to set an 'active' flag for that member in the complete witness/committee list.

Then, the open-explorer controllers can simply use the active flag to separate the active from the standby members without looking at count and/or votes.

Essentially, votes are tallied for active objects only. But past tallied votes are not cleared when the object is made inactive (this might be something to fix in -core).

So a member might appear to have more votes but only because he hasn't been in the active list in a while for the total to be recalculated.