search

bitshifter / glam-rs

A simple and fast linear algebra library for games and graphics
Apache License 2.0
1.46k stars 145 forks source link

clippy: Fix `let_and_return` lint in neon. #509

Closed waywardmonkeys closed 2 months ago

bitshifter commented 2 months ago

This one is generated so you'll need to update the template and rerun codegen, or I can do it if you prefer.

bitshifter commented 2 months ago

Looking at the template it might be easier to add It might be easier to add #[allow(clippy::let_and_return)] here.

waywardmonkeys commented 2 months ago

I just updated the template and thought about the same thing ... but tried this as well. What do you think?

bitshifter commented 2 months ago

That works as well :)

waywardmonkeys commented 2 months ago

I had also tried just doing unsafe { ... } & 0x7 but that didn't looked bad to me in the generated re-formatted code.

waywardmonkeys commented 2 months ago

And the reason this didn't get picked up by CI is that clippy is just run on the ubuntu build, not all platforms / configs.

bitshifter commented 2 months ago

Ah, I was wondering. I should do something about that.