Fix vector clamp length methods to not accept negative values

bitshifter / glam-rs

A simple and fast linear algebra library for games and graphics

Apache License 2.0

1.46k stars 145 forks source link

Closed semihbkgr closed 2 months ago

semihbkgr commented 2 months ago

fixes #515

bitshifter commented 2 months ago

That looks good to me. Note that most code in glam is generated, see https://github.com/bitshifter/glam-rs/blob/main/codegen%2FREADME.md for how to run codegen.

Could you add a test for the problem you are fixing as well?

bitshifter commented 2 months ago

Sorry, I had some more thoughts on this which I've posted on the original issue.

bitshifter commented 2 months ago

GitHub is saying there are merge conflicts, not sure why.

You'd need to pull latest. Usually I rebase on top of latest and force push to the PR branch.

Oh, you've done it already :)

semihbkgr commented 2 months ago

I got the same conflit on my local fork. To resolve, I just merged the latest main branch into this branch.

bitshifter commented 2 months ago

Thanks for reporting this and the PR!