bitshifter / glam-rs

A simple and fast linear algebra library for games and graphics
Apache License 2.0
1.5k stars 152 forks source link

Remove normalized assertions from `mul_quat` #560

Closed fu5ha closed 3 weeks ago

fu5ha commented 4 weeks ago

It makes sense to ensure that quaternions are normalized before using them to do things that require them to be normalized to make sense (like transforming a vector), but it is entirely valid to multiply non-normalized quaternions. Such a use case is in implementing dual quaternions, in which case we routinely multiply the (normalized) real-part quat with the (non-normalized in and of itself) dual-part quat.